[ 
https://issues.apache.org/jira/browse/FLINK-18588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157430#comment-17157430
 ] 

Jark Wu commented on FLINK-18588:
---------------------------------

[~wtog] I CC'ed someone familiar with this part to review in the PR. 

> hive ddl create table should support 'if not exists'
> ----------------------------------------------------
>
>                 Key: FLINK-18588
>                 URL: https://issues.apache.org/jira/browse/FLINK-18588
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>    Affects Versions: 1.11.0
>            Reporter: wangtong
>            Priority: Minor
>              Labels: pull-request-available
>
> FlinkHiveSqlParser cant parse sql 'create table if not exists tbl (x int)' 
> due to 'if not exists'
> {code:java}
> // code placeholder
> java.lang.RuntimeException: Error while parsing SQL: create table if not 
> exists tbl (x int)java.lang.RuntimeException: Error while parsing SQL: create 
> table if not exists tbl (x int)
>  at 
> org.apache.calcite.sql.parser.SqlParserTest$TesterImpl.parseStmtAndHandleEx(SqlParserTest.java:8861)
>  at 
> org.apache.calcite.sql.parser.SqlParserTest$TesterImpl.check(SqlParserTest.java:8845)
>  at 
> org.apache.calcite.sql.parser.SqlParserTest$Sql.ok(SqlParserTest.java:9192) 
> at 
> org.apache.flink.sql.parser.hive.FlinkHiveSqlParserImplTest.testCreateTable(FlinkHiveSqlParserImplTest.java:177)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498) at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at 
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at 
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at 
> org.junit.runners.ParentRunner.run(ParentRunner.java:363) at 
> org.junit.runner.JUnitCore.run(JUnitCore.java:137) at 
> org.junit.runner.JUnitCore.run(JUnitCore.java:115) at 
> org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:40)
>  at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) 
> at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) 
> at java.util.Iterator.forEachRemaining(Iterator.java:116) at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
>  at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) 
> at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) 
> at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
>  at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) at 
> org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80)
>  at 
> org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:71) 
> at 
> org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:229)
>  at 
> org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:197)
>  at 
> org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:211)
>  at 
> org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:191)
>  at 
> org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
>  at 
> com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:69)
>  at 
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
>  at 
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
>  at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)Caused by: 
> org.apache.calcite.sql.parser.SqlParseException: Encountered "not" at line 1, 
> column 17.Was expecting one of:    <EOF>     "ROW" ...    "COMMENT" ...    
> "LOCATION" ...    "PARTITIONED" ...    "STORED" ...    "TBLPROPERTIES" ...    
> "(" ...    "." ...
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to