shuttie opened a new pull request #12929:
URL: https://github.com/apache/flink/pull/12929


   ## What is the purpose of the change
   
   A [custom serializer for scala 
ADT](https://issues.apache.org/jira/browse/FLINK-18631) sealed trait class 
hierarchies. Using ADTs in Scala with Flink always resulted in severe 
performance degradation due to Kryo fallback, which we hopefully trying to 
address in this PR.
   
   ## Brief change log
   
     - SealedTraitSerializer and SealedTraitTypeInfo implementation for sealed 
trait serialization support.
     - TODO: add a test for SealedTraitTypeInfo
     - TODO: PR to apache/flink-benchmarks with benchmark code showing the 
impact
     - TODO: add migration support if ADT is extended with new members
     - TODO: mention limitations of ADT support in the docs (like generic ADTs)
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   - added a normal and nested ADT tests to ScalaSpecialTypesSerializerTest
   - added new test SealedTraitSerializerTest
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: **yes**
     - The runtime per-record code paths (performance sensitive): **yes**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to