azagrebin commented on a change in pull request #12981:
URL: https://github.com/apache/flink/pull/12981#discussion_r460101119



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableImpl.java
##########
@@ -134,6 +143,12 @@ public TaskSlotTableImpl(
                slotActions = null;
                state = State.CREATED;
                closingFuture = new CompletableFuture<>();
+
+               asyncExecutor = new ThreadPoolExecutor(
+                       0,
+                       numberSlots,
+                       60L, TimeUnit.SECONDS,
+                       new SynchronousQueue<>());

Review comment:
       What kind of test do you mean? That the closing verification is 
off-loaded? I want the executor to allocate a new thread if there is no idle 
one for each slot closing but I do not want to keep idle threads too long. Is 
it not how the `ThreadPoolExecutor` is specified?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to