Myracle commented on a change in pull request #12958:
URL: https://github.com/apache/flink/pull/12958#discussion_r460593997



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -299,6 +303,8 @@ public void start(ResourceManagerId newResourceManagerId, 
Executor newMainThread
                        TimeUnit.MILLISECONDS);
 
                registerSlotManagerMetrics();
+
+               allocateRedundantSlots(redundantSlotNum);

Review comment:
       After offline discussion, SlotManagerImpl will not allocate redundant 
taskmanagers at start for that it is hard to know wether there exist enough 
redundant taskmanagers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to