aljoscha commented on a change in pull request #13024:
URL: https://github.com/apache/flink/pull/13024#discussion_r463093008
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
##########
@@ -704,7 +708,7 @@ protected void executeProgram(final Configuration
configuration, final PackagedP
*
* @return A PackagedProgram (upon success)
*/
- PackagedProgram buildProgram(final ProgramOptions runOptions)
+ PackagedProgram buildProgram(final ProgramOptions runOptions, boolean
setConfiguration)
Review comment:
Is this additional parameter only introduced for tests? In production
code I can only see `false` as a parameter. If yes, then we should find a
different solution because we should not introduce code in production code that
is only used in tests.
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrap.java
##########
@@ -293,10 +294,15 @@ private void runApplicationEntryPoint(
}
if (serializedThrowable.isPresent()) {
- Throwable throwable =
- serializedThrowable
- .get()
-
.deserializeError(application.getUserCodeClassLoader());
+ Throwable throwable;
+ try {
+ throwable = serializedThrowable
+ .get()
+
.deserializeError(application.getUserCodeClassLoader());
+ } catch (ProgramInvocationException e) {
Review comment:
Why do we catch this here now?
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -516,7 +590,7 @@ private static void checkJarFile(URL jarfile) throws
ProgramInvocationException
private List<URL> userClassPaths = Collections.emptyList();
- private Configuration configuration = new Configuration();
+ private Configuration configuration = null;
Review comment:
Why don't we set a default, empty `Configuration` anymore? Like this we
need to add a lot of calls in tests that just set an empty `Configuration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
