[
https://issues.apache.org/jira/browse/FLINK-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140889#comment-15140889
]
ASF GitHub Bot commented on FLINK-3377:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1609#issuecomment-182401273
taken from the jira isue:
The final flag on the
org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter class is
causing issues for me.
The flag requires me to run a test I'm working on with a
@RunWith(PowerMockRunner.class) annotation so that i can use @PrepareForTest(
{ResultPartitionWriter.class}
).
But it breaks my TemporaryFolder annotated with @ClassRule. (apart from
that there also was a classloader issue, but i could resolve that)
To me these seem like unnecessary problems, as such i propose removing the
final flag.
> Remove final flag from ResultPartitionWriter class
> --------------------------------------------------
>
> Key: FLINK-3377
> URL: https://issues.apache.org/jira/browse/FLINK-3377
> Project: Flink
> Issue Type: Wish
> Components: Distributed Runtime
> Affects Versions: 0.10.1
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.00
>
>
> The final flag on the
> org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter class is
> causing issues for me.
> The flag requires me to run a test I'm working on with a
> @RunWith(PowerMockRunner.class) annotation so that i can use
> @PrepareForTest({ResultPartitionWriter.class}).
> But it breaks my TemporaryFolder annotated with @ClassRule. (apart from that
> there also was a classloader issue, but i could resolve that)
> To me these seem like unnecessary problems, as such i propose removing the
> final flag.
> The
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
