[ 
https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140920#comment-15140920
 ] 

ASF GitHub Bot commented on FLINK-2237:
---------------------------------------

Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r52467302
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java
 ---
    @@ -100,340 +101,371 @@
        @Test
        public void testDifferentProbers() {
                final int NUM_MEM_PAGES = 32 * NUM_PAIRS / PAGE_SIZE;
    -           
    -           AbstractMutableHashTable<IntPair> table = new 
CompactingHashTable<IntPair>(serializer, comparator, getMemory(NUM_MEM_PAGES, 
PAGE_SIZE));
    -           
    +           testDifferentProbersCore(new CompactingHashTable<>(serializer, 
comparator, getMemory(NUM_MEM_PAGES, PAGE_SIZE)), NUM_MEM_PAGES);
    --- End diff --
    
    I can do that, but I would like to ask why is that important. I mean if one 
of these tests fail, then one of the lines can be simply commented out to see 
which hash table is making it fail.


> Add hash-based Aggregation
> --------------------------
>
>                 Key: FLINK-2237
>                 URL: https://issues.apache.org/jira/browse/FLINK-2237
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Rafiullah Momand
>            Assignee: Gabor Gevay
>            Priority: Minor
>
> Aggregation functions at the moment are implemented in a sort-based way.
> How can we implement hash based Aggregation for Flink?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to