[ 
https://issues.apache.org/jira/browse/FLINK-18704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177020#comment-17177020
 ] 

Fabian Hueske commented on FLINK-18704:
---------------------------------------

Thanks for picking this up [~micg]!

Since datagen is just a connector for testing and demonstration purposes, I 
wouldn't worry too much about the "correctness" of the generated data.
Of course the returned values should be in the value range of the specified 
BigDecimal type.
For me it would be fine if we just generate a double value that's in the value 
range of the BigDecimal type and then cast it to BigDecimal.

 

> Support DECIMAL types in datagen Table source connector
> -------------------------------------------------------
>
>                 Key: FLINK-18704
>                 URL: https://issues.apache.org/jira/browse/FLINK-18704
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Ecosystem
>    Affects Versions: 1.11.0, 1.11.1
>            Reporter: Fabian Hueske
>            Priority: Major
>              Labels: starter
>
> It would be great if the [{{datagen}} source 
> connector|https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/connectors/datagen.html]
>  would support {{DECIMAL}} types.
> Since data is randomly generated and FLOAT and DOUBLE are supported, we could 
> implement this feature by creatig a {{BigDecimal}} from a random float.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to