[
https://issues.apache.org/jira/browse/FLINK-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142765#comment-15142765
]
ASF GitHub Bot commented on FLINK-3364:
---------------------------------------
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1622
[FLINK-3364] [runtime, yarn] Move SavepointStore initialization out of
JobManager constructor
Initializing the `SavepointStore` can fail. Doing this in the `JobManager`
constructor is bad, because it is done by an asynchronous Akka thread. With
this change, we fail early as with the other `JobManager` components.
It's a pretty straight forward change. Waiting for Travis before merging
this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 3364-savepoint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1622.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1622
----
commit 31eb796693c680efd9eec2a63229a83a6753e470
Author: Ufuk Celebi <[email protected]>
Date: 2016-02-11T13:58:35Z
[FLINK-3364] [runtime, yarn] Move SavepointStore initialization out of
JobManager constructor
----
> Don't initialize SavepointStore in JobManager constructor
> ---------------------------------------------------------
>
> Key: FLINK-3364
> URL: https://issues.apache.org/jira/browse/FLINK-3364
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
> Priority: Critical
> Fix For: 1.0.0
>
>
> As with other components of the JobManager, the SavepointStore should be
> passed to the JobManager and not instantiated in the JobManager constructor.
> Failures during instantiation are otherwise not noticed, because of
> asynchronous instantiation via Akka.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
