[
https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142780#comment-15142780
]
ASF GitHub Bot commented on FLINK-2237:
---------------------------------------
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r52605362
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java
---
@@ -45,9 +45,12 @@ public RandomAccessInputView(ArrayList<MemorySegment>
segments, int segmentSize)
{
this(segments, segmentSize, segmentSize);
}
-
+
+ /**
+ * Warning: setReadPosition has to be called before reading.
+ */
public RandomAccessInputView(ArrayList<MemorySegment> segments, int
segmentSize, int limitInLastSegment) {
--- End diff --
I tried this, but it turned out that there is no nice way to do it, because
the two constructors would have the same parameters, so I had to add a dummy
parameter. (See
https://github.com/apache/flink/commit/508ce22c3167dc6e6e2a4a6b9776b6c79e62698f)
Do you think that this ugly solution is worth it, or should I revert to the
original?
> Add hash-based Aggregation
> --------------------------
>
> Key: FLINK-2237
> URL: https://issues.apache.org/jira/browse/FLINK-2237
> Project: Flink
> Issue Type: New Feature
> Reporter: Rafiullah Momand
> Assignee: Gabor Gevay
> Priority: Minor
>
> Aggregation functions at the moment are implemented in a sort-based way.
> How can we implement hash based Aggregation for Flink?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
