kl0u commented on pull request #13024: URL: https://github.com/apache/flink/pull/13024#issuecomment-677730660
@wangzzu In your testing code you seem to "replicate" the code of the `CliFrontend.run()` method. This is pretty fragile because if someone changes the order of the calls in the run, the test will still pass. Can't you follow a similar pattern as in the `CliFrontendRunTest` where you override the `executeProgram(Configuration configuration, PackagedProgram program)` (see `RunTestingCliFrontend` at the bottom of the class)? This will also allow to avoid make methods visible just for testing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
