tillrohrmann commented on a change in pull request #13217:
URL: https://github.com/apache/flink/pull/13217#discussion_r475565191
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -350,71 +341,42 @@ private boolean isPartialResourceConfigured(JobGraph
jobGraph) {
}, getRpcService().getExecutor());
}
- private CompletableFuture<Void> persistAndRunJob(JobGraph jobGraph)
throws Exception {
+ private Void persistAndRunJob(JobGraph jobGraph) throws Exception {
Review comment:
Hmm, I think the problem is that you are using `persistAndRunJob` still
as a function even though it does not return anything. Changing
`waitForTerminatingJobManager` to take a `ThrowingConsumer` should solve the
problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
