xintongsong commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476973166
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java ########## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.GlobalConfiguration; +import org.apache.flink.configuration.TaskManagerOptions; +import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions; +import org.apache.flink.kubernetes.configuration.KubernetesResourceManagerDriverConfiguration; +import org.apache.flink.kubernetes.kubeclient.FlinkKubeClient; +import org.apache.flink.kubernetes.kubeclient.factory.KubernetesTaskManagerFactory; +import org.apache.flink.kubernetes.kubeclient.parameters.KubernetesTaskManagerParameters; +import org.apache.flink.kubernetes.kubeclient.resources.KubernetesPod; +import org.apache.flink.kubernetes.kubeclient.resources.KubernetesWatch; +import org.apache.flink.kubernetes.utils.KubernetesUtils; +import org.apache.flink.runtime.clusterframework.ApplicationStatus; +import org.apache.flink.runtime.clusterframework.BootstrapTools; +import org.apache.flink.runtime.clusterframework.ContaineredTaskManagerParameters; +import org.apache.flink.runtime.clusterframework.TaskExecutorProcessSpec; +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.concurrent.FutureUtils; +import org.apache.flink.runtime.externalresource.ExternalResourceUtils; +import org.apache.flink.runtime.resourcemanager.active.AbstractResourceManagerDriver; +import org.apache.flink.runtime.resourcemanager.active.ResourceManagerDriver; +import org.apache.flink.runtime.resourcemanager.exceptions.ResourceManagerException; +import org.apache.flink.util.ExceptionUtils; +import org.apache.flink.util.FlinkException; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; + +/** + * Implementation of {@link ResourceManagerDriver} for Kubernetes deployment. + */ +public class KubernetesResourceManagerDriver extends AbstractResourceManagerDriver<KubernetesWorkerNode> + implements FlinkKubeClient.PodCallbackHandler { + + /** The taskmanager pod name pattern is {clusterId}-{taskmanager}-{attemptId}-{podIndex}. */ + private static final String TASK_MANAGER_POD_FORMAT = "%s-taskmanager-%d-%d"; + + private final String clusterId; + + private final Time podCreationRetryInterval; + + private final FlinkKubeClient kubeClient; + + /** Request resource futures, keyed by pod names. */ + private final Map<String, CompletableFuture<KubernetesWorkerNode>> requestResourceFutures; + + /** When ResourceManager failover, the max attempt should recover. */ + private long currentMaxAttemptId = 0; + + /** Current max pod index. When creating a new pod, it should increase one. */ + private long currentMaxPodId = 0; + + private KubernetesWatch podsWatch; + + /** + * Incompletion of this future indicates that there was a pod creation failure recently and the driver should not + * retry creating pods until the future become completed again. It's guaranteed to be modified in main thread. + */ + private CompletableFuture<Void> podCreationCoolDown; + + public KubernetesResourceManagerDriver( + Configuration flinkConfig, + FlinkKubeClient kubeClient, + KubernetesResourceManagerDriverConfiguration configuration) { + super(flinkConfig, GlobalConfiguration.loadConfiguration()); + + this.clusterId = Preconditions.checkNotNull(configuration.getClusterId()); + this.podCreationRetryInterval = Preconditions.checkNotNull(configuration.getPodCreationRetryInterval()); + this.kubeClient = Preconditions.checkNotNull(kubeClient); + this.requestResourceFutures = new HashMap<>(); + this.podCreationCoolDown = FutureUtils.completedVoidFuture(); + } + + // ------------------------------------------------------------------------ + // ResourceManagerDriver + // ------------------------------------------------------------------------ + + @Override + protected void initializeInternal() throws Exception { + recoverWorkerNodesFromPreviousAttempts(); + + podsWatch = kubeClient.watchPodsAndDoCallback( + KubernetesUtils.getTaskManagerLabels(clusterId), + this); + } + + @Override + public CompletableFuture<Void> terminate() { + // shut down all components + Exception exception = null; + + try { + podsWatch.close(); + } catch (Exception e) { + exception = e; + } + + try { + kubeClient.close(); + } catch (Exception e) { + exception = ExceptionUtils.firstOrSuppressed(e, exception); + } + + return exception == null ? + FutureUtils.completedVoidFuture() : + FutureUtils.completedExceptionally(exception); + } + + @Override + public void deregisterApplication(ApplicationStatus finalStatus, @Nullable String optionalDiagnostics) { + log.info("Deregistering flink kubernetes cluster, clusterId: {}, diagnostics: {}", + clusterId, + optionalDiagnostics == null ? "" : optionalDiagnostics); + kubeClient.stopAndCleanupCluster(clusterId); + } + + @Override + public CompletableFuture<KubernetesWorkerNode> requestResource(TaskExecutorProcessSpec taskExecutorProcessSpec) { + final KubernetesTaskManagerParameters parameters = + createKubernetesTaskManagerParameters(taskExecutorProcessSpec); + final KubernetesPod taskManagerPod = + KubernetesTaskManagerFactory.buildTaskManagerKubernetesPod(parameters); + final String podName = taskManagerPod.getName(); + final CompletableFuture<KubernetesWorkerNode> requestResourceFuture = new CompletableFuture<>(); + + requestResourceFutures.put(podName, requestResourceFuture); + + log.info("Creating new TaskManager pod with name {} and resource <{},{}>.", + podName, + parameters.getTaskManagerMemoryMB(), + parameters.getTaskManagerCPU()); + + // When K8s API Server is temporary unavailable, `kubeClient.createTaskManagerPod` might fail immediately. + // In case of pod creation failures, we should wait for an interval before trying to create new pods. + // Otherwise, ActiveResourceManager will always re-requesting the worker, which keeps the main thread busy. + final CompletableFuture<Void> createPodFuture = Review comment: My answer would be no. On Yarn, when calling `AMRMClientAsync.addContainerRequest`, the request is first added to the local client, then sent to Yarn RM via heartbeats. This prevents the requests from being failed and re-requested immediately. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
