rkhachatryan commented on a change in pull request #13209: URL: https://github.com/apache/flink/pull/13209#discussion_r477546527
########## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java ########## @@ -609,6 +609,33 @@ public void testShuffleModeUndefined() { sourceAndMapVertex.getProducedDataSets().get(0).getResultType()); } + @Test(expected = UnsupportedOperationException.class) + public void testConflictShuffleModeWithBufferTimeout() { + testCompatibleShuffleModeWithBufferTimeout(ShuffleMode.BATCH); + } + + @Test + public void testNormalShuffleModeWithBufferTimeout() { + testCompatibleShuffleModeWithBufferTimeout(ShuffleMode.PIPELINED); + } + + private void testCompatibleShuffleModeWithBufferTimeout(ShuffleMode shuffleMode) { + StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); + + DataStream<Integer> sourceDataStream = env.fromElements(1, 2, 3); + sourceDataStream.getTransformation().setBufferTimeout(100); Review comment: If we keep using the default timeout ([discussion above](https://github.com/apache/flink/pull/13209#discussion_r477537338)), then the issue also happens with `StreamExecutionEnvironment.setBufferTimeout(100)` or even default, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org