[ 
https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144710#comment-15144710
 ] 

ASF GitHub Bot commented on FLINK-3340:
---------------------------------------

Github user ggevay commented on the pull request:

    https://github.com/apache/flink/pull/1626#issuecomment-183375884
  
    Sorry, but I don't think it is independent, because the bug in the reduce 
drivers could alternatively be fixed by saying that the bug is actually not in 
the reduce drivers at all, but in `MergeIterator`, and fix it there instead (as 
in 
https://github.com/ggevay/flink/commit/b05e12075bb5d0518b6fe12cd8f7de1e6b16f805).
 This depends on what we want the contract of `MergeIterator.next(reuse)` to be.


> Fix object juggling in drivers
> ------------------------------
>
>                 Key: FLINK-3340
>                 URL: https://issues.apache.org/jira/browse/FLINK-3340
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>    Affects Versions: 1.0.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Critical
>
> {{ReduceDriver}}, {{ReduceCombineDriver}}, and {{ChainedAllReduceDriver}} are 
> not properly tracking objects for reuse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to