zhijiangW commented on a change in pull request #13209:
URL: https://github.com/apache/flink/pull/13209#discussion_r479080606
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -285,11 +285,7 @@ public StreamGraph generate() {
alreadyTransformed.put(transform, transformedIds);
}
- if (transform.getBufferTimeout() >= 0) {
- streamGraph.setBufferTimeout(transform.getId(),
transform.getBufferTimeout());
- } else {
- streamGraph.setBufferTimeout(transform.getId(),
defaultBufferTimeout);
Review comment:
The motivation is for setting the default timeout (100) only for
streaming job by design. But in this procedure we can not determine the
`ResultPartitionType` for properly setting the default value, so I removed that
path before. And actually the default value can also be set/got in the
following procedure by `StreamConfig`.
But I found another problem to do so, which will effect some other code
paths. Now I adjusted to make all the preceding default values as `-1` if not
explicitly set. Then during job graph generation, we can determine whether to
reset the default value `100` only for pipelined partition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
