[jira] [Commented] (FLINK-19064) HBaseRowDataInputFormat is leaking resources

[Nicholas Jiang (Jira)]

    [ 
https://issues.apache.org/jira/browse/FLINK-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187456#comment-17187456
 ] 

Nicholas Jiang commented on FLINK-19064:
----------------------------------------

Back to this issue, method 
DataSourceNode#computeOperatorSpecificDefaultEstimates only calls 
format#configure, doesn't call format#close. In my opinion, method 
computeOperatorSpecificDefaultEstimates should close the format, in another 
word, which configure the format should be responsible for closing the format.

> HBaseRowDataInputFormat is leaking resources
> --------------------------------------------
>
>                 Key: FLINK-19064
>                 URL: https://issues.apache.org/jira/browse/FLINK-19064
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / HBase
>    Affects Versions: 1.12.0
>            Reporter: Robert Metzger
>            Assignee: Nicholas Jiang
>            Priority: Critical
>              Labels: pull-request-available
>
> {{HBaseRowDataInputFormat.configure()}} is calling {{connectToTable()}}, 
> which creates a connection to HBase that is not closed again.
> A user reported this problem on the user@ list: 
> https://lists.apache.org/thread.html/ra04f6996eb50ee83aabd2ad0d50bec9afb6a924bfbb48ada3269c6d8%40%3Cuser.flink.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)