dawidwys commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r481031562



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1180,6 +1181,14 @@ public final CloseableRegistry getCancelables() {
                        }
                }
 
+               // Clones the partition to avoid multiple stream edges sharing 
the same stream partitioner,
+               // like the case of 
https://issues.apache.org/jira/browse/FLINK-14087.
+               try {
+                       outputPartitioner = 
InstantiationUtil.clone(outputPartitioner, 
Thread.currentThread().getContextClassLoader());

Review comment:
       In my opinion we should clone the partitioner before configuring it. I 
think the `configure` can theoretically initialize some state that is not 
serializable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to