rmetzger commented on a change in pull request #13260:
URL: https://github.com/apache/flink/pull/13260#discussion_r481140585



##########
File path: tools/ci/watchdog.sh
##########
@@ -38,8 +38,26 @@ CMD_EXIT="/tmp/watchdog.exit"
 # Utility functions
 # ============================================= 
 
+max_of() {
+  local max number
+
+  max="$1"
+
+  for number in "${@:2}"; do
+    if ((number > max)); then
+      max="$number"
+    fi
+  done
+
+  printf '%d\n' "$max"

Review comment:
       Well, my code is (of course) inspired by Stackoverflow. 
   But there seems to be some arguments why printf is better than echo: 
https://unix.stackexchange.com/questions/65803/why-is-printf-better-than-echo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to