WeiZhong94 commented on a change in pull request #13304:
URL: https://github.com/apache/flink/pull/13304#discussion_r482665098
##########
File path: flink-python/pyflink/table/tests/test_window.py
##########
@@ -40,8 +41,8 @@ class BatchTableWindowTests(PyFlinkBatchTableTestCase):
def test_tumble_window(self):
t = self.t_env.from_elements([(1, 1, "Hello")], ["a", "b", "c"])
- result = t.window(Tumble.over("2.rows").on("a").alias("w"))\
- .group_by("w, c").select("b.sum")
+ result = t.window(Tumble.over(E.lit(2).rows).on("a").alias("w"))\
Review comment:
".rows" seems not supported. Maybe we should support it or use
"row_interval()" instead?
##########
File path: flink-python/pyflink/table/tests/test_pandas_udf.py
##########
@@ -58,8 +59,8 @@ def test_basic_functionality(self):
t = self.t_env.from_elements([(1, 2, 3), (2, 5, 6), (3, 1, 9)], ['a',
'b', 'c'])
exec_insert_table(
- t.where("add_one(b) <= 3").select("a, b + 1, add(a + 1,
subtract_one(c)) + 2, "
- "add(add_one(a), 1L)"),
+ t.where(E.call('add_one', t.b) <= 3)
+ .select("a, b + 1, add(a + 1, subtract_one(c)) + 2, "
"add(add_one(a), 1L)"),
Review comment:
combine to one string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
