sujun1020 commented on a change in pull request #13306:
URL: https://github.com/apache/flink/pull/13306#discussion_r483439249
##########
File path:
flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcFileSystemFormatFactory.java
##########
@@ -83,14 +96,227 @@ private static Properties getOrcProperties(ReadableConfig
options) {
return orcProperties;
}
+ private boolean isUnaryValid(CallExpression callExpression) {
Review comment:
@JingsongLi thanks for your review, do you mean that all the codes
related to filter pushdown conversion below are put in the class OrcFilters ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
