lsyldliu commented on a change in pull request #11830:
URL: https://github.com/apache/flink/pull/11830#discussion_r485384295
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/aggregate/GroupAggFunction.java
##########
@@ -83,61 +85,57 @@
// stores the accumulators
private transient ValueState<RowData> accState = null;
+ private final StateTtlConfig ttlConfig;
Review comment:
@wuchong sorry, I looked the code again, `ttlConfig` object also used in
`processElement` method, so it must be global object. However, it only used in
`open` method in other classes, to keep consistent, I think we can set
ttlConfig as global object in other classes, what do you think？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
