gaoyunhaii commented on a change in pull request #13343:
URL: https://github.com/apache/flink/pull/13343#discussion_r485459421
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
##########
@@ -567,28 +565,14 @@ private void addEdgeInternal(Integer upStreamVertexID,
shuffleMode = ShuffleMode.UNDEFINED;
}
- StreamEdge edge = new StreamEdge(upstreamNode,
downstreamNode, typeNumber, outputNames, partitioner, outputTag, shuffleMode);
+ StreamEdge edge = new StreamEdge(upstreamNode,
downstreamNode, typeNumber,
+ partitioner, outputTag, shuffleMode);
getStreamNode(edge.getSourceId()).addOutEdge(edge);
getStreamNode(edge.getTargetId()).addInEdge(edge);
}
}
- public <T> void addOutputSelector(Integer vertexID, OutputSelector<T>
outputSelector) {
Review comment:
It seems we should also remove `addVirtualSelectNode` method, the
related `virtualSelectNodes` map and its occurrence ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
