wuchong commented on a change in pull request #11830:
URL: https://github.com/apache/flink/pull/11830#discussion_r486054242
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/aggregate/GroupAggFunction.java
##########
@@ -180,7 +179,7 @@ public void processElement(RowData input, Context ctx,
Collector<RowData> out) t
// if this was not the first row and we have to emit
retractions
if (!firstRow) {
- if (!stateCleaningEnabled &&
equaliser.equals(prevAggValue, newAggValue)) {
+ if (stateRetentionTime > 0 &&
equaliser.equals(prevAggValue, newAggValue)) {
Review comment:
I think this is the one causes `RetractionITCase#testUniqueProcess`
failed. Here should be `stateRetentionTime <= 0` to indicate state cleaning is
not enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
