[ 
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194649#comment-17194649
 ] 

dalongliu commented on FLINK-19207:
-----------------------------------

[~jark] after study the source code of IteratorWithCleanup class, I found that 
it is not easy to support remove method in it, for HeapListState, 
originalIterator is original object in state, so we can easily remove it, but 
for RocksdbListState, originalIterator is a new List which element get from 
state, we can't remove element in state directly. If we want to support remove 
method for IteratorWithCleanup, we maybe refactor it. what do you think it? 
[~azagrebin]

> TtlListState#IteratorWithCleanup support remove method
> ------------------------------------------------------
>
>                 Key: FLINK-19207
>                 URL: https://issues.apache.org/jira/browse/FLINK-19207
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / State Backends
>    Affects Versions: 1.12.0
>            Reporter: dalongliu
>            Priority: Critical
>
> In Flink-17096 , we are using TTL State refactor group Agg function state 
> expiration implement instead of Timer way. However, there’s a slight problem 
> which AggregateITCase#testListAggWithRetraction test failed because of 
> *IteratorWithCleanup* didn't support remove element, so maybe we need to 
> support {{remove}} for {{TtlListState#IteratorWithCleanup.}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to