AHeise opened a new pull request #13383: URL: https://github.com/apache/flink/pull/13383
(Unchanged backport of https://github.com/apache/flink/pull/13000) ## What is the purpose of the change Wait for the LegacySourceFunctionThread to finish when cancelling the task. This prevents premature freeing of resources, particularly LibraryCache (see [FLINK-15467](https://issues.apache.org/jira/browse/FLINK-15467) discussion). Implemented by waiting in `SourceStreamTask.invoke()` for the `sourceThread` to complete. There were several existing tests failures (listed below) which were fixed by completing the future if thread isn't alive; or by returning a completed future if a task is failing. ## Verifying this change * Added unit test: `SourceStreamTaskTest.testWaitsForSourceThreadOnCancel` * Tested manually on a local cluster * Existing tests covering different scenarios of task exit and cancellation: `InterruptSensitiveRestoreTest`, `StreamTaskTest.testEarlyCanceling`, `FastFailuresITCase` ## Does this pull request potentially affect one of the following parts: * Dependencies (does it add or upgrade a dependency): no * The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no * The serializers: no * The runtime per-record code paths (performance sensitive): no * Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no * The S3 file system connector: no ## Documentation * Does this pull request introduce a new feature? no * If yes, how is the feature documented? no ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
