KarmaGYZ commented on a change in pull request #13311:
URL: https://github.com/apache/flink/pull/13311#discussion_r488494767
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/config/memory/CommonProcessMemorySpec.java
##########
@@ -101,7 +101,7 @@ public MemorySize getTotalProcessMemorySize() {
public boolean equals(Object obj) {
if (obj == this) {
return true;
- } else if (obj instanceof CommonProcessMemorySpec<?> ) {
+ } else if (getClass().equals(obj.getClass()) && obj instanceof
CommonProcessMemorySpec<?> ) {
Review comment:
I think the first approach would be good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
