XComp commented on a change in pull request #13311:
URL: https://github.com/apache/flink/pull/13311#discussion_r488567261
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManagerFactory.java
##########
@@ -104,5 +104,5 @@ private Configuration
createActiveResourceManagerConfiguration(Configuration ori
resourceManagerMetricGroup);
}
- protected abstract ResourceManagerDriver<WorkerType>
createResourceManagerDriver(Configuration configuration);
+ protected abstract ResourceManagerDriver<WorkerType>
createResourceManagerDriver(Configuration configuration, String
webInterfaceUrl, String rpcAddress);
Review comment:
I was just concerned about changing a method signature of the super
class to make it fit to a single subclass (`YarnResourceManagerFactory` in this
case). But you're right. I already realized that `MesosResourceManagerFactory`
seems to use `webInterfaceUrl` as well, at least.
Maybe, your solution is still the best approach without introducing new
classes and, therefore, making the code overall more complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
