igalshilman commented on a change in pull request #153: URL: https://github.com/apache/flink-statefun/pull/153#discussion_r489499054
########## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/ReflectiveFlinkConfigExtractor.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.statefun.flink.core; + +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; + +class ReflectiveFlinkConfigExtractor { Review comment: nit: could be `final` ########## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfig.java ########## @@ -106,20 +104,12 @@ * current environment set via the {@code flink-conf.yaml}. */ public static StatefulFunctionsConfig fromEnvironment(StreamExecutionEnvironment env) { - Configuration configuration = getConfiguration(env); + Configuration configuration = ReflectiveFlinkConfigExtractor.extractFromEnv(env); return new StatefulFunctionsConfig(configuration); } - private static Configuration getConfiguration(StreamExecutionEnvironment env) { - try { - Method getConfiguration = - StreamExecutionEnvironment.class.getDeclaredMethod("getConfiguration"); - getConfiguration.setAccessible(true); - return (Configuration) getConfiguration.invoke(env); - } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) { - throw new RuntimeException( - "Failed to acquire the Flink configuration from the current environment", e); - } + public static StatefulFunctionsConfig fromFlinkConfiguration(Configuration flinkConfiguration) { Review comment: 💯 ########## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/ReflectiveFlinkConfigExtractor.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.statefun.flink.core; + +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; + +class ReflectiveFlinkConfigExtractor { + + static Configuration extractFromEnv(StreamExecutionEnvironment env) { Review comment: I know that it is an existing code that was refactored out to a new class, but while we are at it, can you add a small comment (for future generations :-) ) that explains why are we extracting reflectivity the configuration? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
