[ https://issues.apache.org/jira/browse/FLINK-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150325#comment-15150325 ]
ASF GitHub Bot commented on FLINK-3379: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1646 > Refactor TimestampExtractor > --------------------------- > > Key: FLINK-3379 > URL: https://issues.apache.org/jira/browse/FLINK-3379 > Project: Flink > Issue Type: Improvement > Components: Streaming > Affects Versions: 0.10.1 > Reporter: Stephan Ewen > Assignee: Stephan Ewen > Priority: Critical > Fix For: 1.0.0 > > > Based on a lot of user feedback, the current {{TimestampExtractor}} seems > very confusing. It implements simultaneously two modes of generating > watermarks: > - Each record that passes through can decide to cause a watermark. > - The timestamp extractor can define a certain watermark timestamp which is > periodically picked up by the system and triggers a watermark (if larger than > the previous watermark). > Figuring out how these modes interplay, and how to define the methods to only > use one mode has been quite an obstacle for several users. We should break > this class into two different classes, one per mode of generating watermarks, > to make it easier to understand. -- This message was sent by Atlassian JIRA (v6.3.4#6332)