dianfu commented on a change in pull request #13462:
URL: https://github.com/apache/flink/pull/13462#discussion_r494728861
##########
File path: flink-python/pyflink/fn_execution/beam/beam_coder_impl_slow.py
##########
@@ -46,8 +46,7 @@ def __init__(self, field_coders):
self._remaining_bits_num = (self._field_count + ROW_KIND_BIT_SIZE) % 8
self.null_mask_search_table = self.generate_null_mask_search_table()
self.null_byte_search_table = (0x80, 0x40, 0x20, 0x10, 0x08, 0x04,
0x02, 0x01)
- self.row_kind_search_table = \
- [i << (8 - ROW_KIND_BIT_SIZE) for i in range(2 **
ROW_KIND_BIT_SIZE)]
+ self.row_kind_search_table = [0x00, 0x80, 0x40, 0xC0]
Review comment:
OK. Then could you add some description on how the search table is
constructed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
