pnowojski commented on a change in pull request #13234:
URL: https://github.com/apache/flink/pull/13234#discussion_r494813570
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTask.java
##########
@@ -53,42 +53,48 @@ public void init() throws Exception {
StreamConfig configuration = getConfiguration();
ClassLoader userClassLoader = getUserCodeClassLoader();
- TypeSerializer<?>[] inputDeserializers =
configuration.getTypeSerializersIn(userClassLoader);
+ StreamConfig.Input[] inputs =
configuration.getInputs(userClassLoader);
- ArrayList<IndexedInputGate>[] inputLists = new
ArrayList[inputDeserializers.length];
- WatermarkGauge[] watermarkGauges = new
WatermarkGauge[inputDeserializers.length];
+ ArrayList<IndexedInputGate>[] inputLists = new ArrayList[
+ (int) Arrays.stream(inputs)
+ .filter(input -> (input instanceof
StreamConfig.NetworkInput))
+ .count()];
Review comment:
@rkhachatryan updated answer to your question:
https://issues.apache.org/jira/browse/FLINK-19411
no it isn't the same :( `configuration.getNumberOfNetworkInputs` returns the
number of input gates of the task, ignoring if they are unioned or not.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTask.java
##########
@@ -53,42 +53,48 @@ public void init() throws Exception {
StreamConfig configuration = getConfiguration();
ClassLoader userClassLoader = getUserCodeClassLoader();
- TypeSerializer<?>[] inputDeserializers =
configuration.getTypeSerializersIn(userClassLoader);
+ StreamConfig.Input[] inputs =
configuration.getInputs(userClassLoader);
- ArrayList<IndexedInputGate>[] inputLists = new
ArrayList[inputDeserializers.length];
- WatermarkGauge[] watermarkGauges = new
WatermarkGauge[inputDeserializers.length];
+ ArrayList<IndexedInputGate>[] inputLists = new ArrayList[
+ (int) Arrays.stream(inputs)
+ .filter(input -> (input instanceof
StreamConfig.NetworkInput))
+ .count()];
Review comment:
Updated answer @rkhachatryan, [no it's not the
same](https://issues.apache.org/jira/browse/FLINK-19411) :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
