tzulitai commented on a change in pull request #10: URL: https://github.com/apache/flink-statefun-docker/pull/10#discussion_r494808247
########## File path: 2.2.0-java11/Dockerfile ########## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM flink:1.11.1-scala_2.12-java11 + +ENV STATEFUN_VERSION=2.2.0 \ + GPG_KEY=1C1E2394D3194E1944613488F320986D35C33D6A + +ENV ROLE worker +ENV MASTER_HOST localhost +ENV STATEFUN_HOME /opt/statefun +ENV STATEFUN_MODULES $STATEFUN_HOME/modules + +# Cleanup flink-lib +RUN rm -fr $FLINK_HOME/lib/flink-table*jar + +# Copy our distriubtion template +COPY flink-distribution/ $FLINK_HOME/ + +# Install Stateful Functions dependencies in Flink lib +ENV DIST_JAR_URL=https://repo.maven.apache.org/maven2/org/apache/flink/statefun-flink-distribution/${STATEFUN_VERSION}/statefun-flink-distribution-${STATEFUN_VERSION}.jar \ + DIST_ASC_URL=https://repo.maven.apache.org/maven2/org/apache/flink/statefun-flink-distribution/${STATEFUN_VERSION}/statefun-flink-distribution-${STATEFUN_VERSION}.jar.asc \ + CORE_JAR_URL=https://repo.maven.apache.org/maven2/org/apache/flink/statefun-flink-core/${STATEFUN_VERSION}/statefun-flink-core-${STATEFUN_VERSION}.jar \ + CORE_ASC_URL=https://repo.maven.apache.org/maven2/org/apache/flink/statefun-flink-core/${STATEFUN_VERSION}/statefun-flink-core-${STATEFUN_VERSION}.jar.asc Review comment: FYI, to test these Dockerfiles, these lines were manually changed to: ``` ENV DIST_JAR_URL=https://repository.apache.org/content/repositories/orgapacheflink-1399/org/apache/flink/statefun-flink-distribution/${STATEFUN_VERSION}/statefun-flink-distribution-${STATEFUN_VERSION}.jar \ DIST_ASC_URL=https://repository.apache.org/content/repositories/orgapacheflink-1399/org/apache/flink/statefun-flink-distribution/${STATEFUN_VERSION}/statefun-flink-distribution-${STATEFUN_VERSION}.jar.asc \ CORE_JAR_URL=https://repository.apache.org/content/repositories/orgapacheflink-1399/org/apache/flink/statefun-flink-core/${STATEFUN_VERSION}/statefun-flink-core-${STATEFUN_VERSION}.jar \ CORE_ASC_URL=https://repository.apache.org/content/repositories/orgapacheflink-1399/org/apache/flink/statefun-flink-core/${STATEFUN_VERSION}/statefun-flink-core-${STATEFUN_VERSION}.jar.asc ``` so that they pointed at the staged artifacts of RC2. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
