walterddr commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r495482128
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/TaskExecutorRegistration.java
##########
@@ -72,13 +77,15 @@ public TaskExecutorRegistration(
final String taskExecutorAddress,
final ResourceID resourceId,
final int dataPort,
+ final int jmxPort,
final HardwareDescription hardwareDescription,
final TaskExecutorMemoryConfiguration
memoryConfiguration,
final ResourceProfile defaultSlotResourceProfile,
final ResourceProfile totalResourceProfile) {
this.taskExecutorAddress = checkNotNull(taskExecutorAddress);
this.resourceId = checkNotNull(resourceId);
this.dataPort = dataPort;
+ this.jmxPort = jmxPort;
Review comment:
after some experiment, it seems like it is modifying a whole lot of
public classes including header/messages in REST API as well as TaskExecutor. I
think separating that into a refactor PR might've been a better idea. what do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
