lirui-apache commented on a change in pull request #13434:
URL: https://github.com/apache/flink/pull/13434#discussion_r495534885
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -195,18 +202,19 @@ private static HiveConf createHiveConf(@Nullable String
hiveConfDir) {
String.format("Failed to get hive-site.xml from
%s", hiveConfDir), e);
}
- // create HiveConf from hadoop configuration
- Configuration hadoopConf =
HadoopUtils.getHadoopConfiguration(new
org.apache.flink.configuration.Configuration());
-
- // Add mapred-site.xml. We need to read configurations like
compression codec.
Review comment:
This comment should be migrated to
`HiveTableUtil::getHadoopConfiguration`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
