Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1677#discussion_r53515589
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/timestamp/TimestampITCase.java
 ---
    @@ -157,13 +157,6 @@ public void testWatermarkPropagation() throws 
Exception {
                                        Assert.fail("Wrong watermark.");
                                }
                        }
    -                   if 
(!CustomOperator.finalWatermarks[i].get(CustomOperator.finalWatermarks[i].size()
 - 1).equals(new Watermark(Long.MAX_VALUE))) {
    --- End diff --
    
    Let's add a test here that validates that this `Long.MAX_VALUE` watermark 
is not present. Something like `assertEquals(NUM_WATERMARKS, 
CustomOperator.finalWatermarks[i].size())`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to