kottmann commented on pull request #13457:
URL: https://github.com/apache/flink/pull/13457#issuecomment-706996982


   @rmetzger the last change adds the OnStartupTriggeringPolicy and the files 
roll now correctly.
   
   I looked at the log4j-session.properties and they currently log only to the 
console and not to file. Therefore I didn't change it.
   
   The log4j-cli.properties logs to a file and doesn't use a rolling policy, I 
can change that to rolling.
   The log4j-console.properties uses the rolling policy and max files to keep 
is set to 10. Maybe it makes sense to do the same for log4j.properties.
   
   Then I noticed that there is a CoreOptions.FLINK_LOG_MAX config parameter, 
is it save to remove it? This will not be used anymore.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to