guoweiM commented on a change in pull request #13576: URL: https://github.com/apache/flink/pull/13576#discussion_r503219281
########## File path: flink-core/src/main/java/org/apache/flink/api/connector/sink/Committer.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.flink.api.connector.sink; + +import org.apache.flink.annotation.Experimental; + +import java.util.List; + +/** + * This interface is responsible for committing the data to the external system. + * + * @param <CommT> The type of the committable data. + */ +@Experimental +public interface Committer<CommT> extends AutoCloseable { + + /** + * Commit the given collection of {@link CommT}. + * @param committable the data needed to be committed. + * @return a collection of {@link CommT} that is needed to re-commit latter. Review comment: >Probably mention that this is needed in case we need to implement a "commit -with -retry" (just to make it clearer). NP. >Also it may make sense to mention when we are going to retry (e.g. at the next notify checkpoint complete). When to retry depend on the execution mode. Even if in the streaming mode there might be some different in the normal checkpoint and at the end of the input(there is no checkpoint any more). So maybe we could not tell the detailed about when to do the retry. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
