StephanEwen commented on pull request #13479: URL: https://github.com/apache/flink/pull/13479#issuecomment-707573526
One more comment: I am not sure that it is good to reuse the `FileSourceTextLinesITCase` for other tests. That is an ITCase that is rather heavy and not very targeted. It is only there so we have one end-2-end execution of a file source. Most of what this test represent is not relevant or helpful to execute for other formats. Instead, what is much more relevant is splitting/checkpointing/restoring, which is not tested here at all. I would suggest to not use this test and instead we should create a testing base for format readers that test the above mentioned aspects (splitting/checkpointing/restoring). The https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/src/impl/AdapterTestBase.java goes in that direction. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
