curcur commented on a change in pull request #13614: URL: https://github.com/apache/flink/pull/13614#discussion_r505183877
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java ########## @@ -305,6 +308,10 @@ BufferAndBacklog pollBuffer() { } } + Buffer buildSliceBuffer(BufferConsumerWithPartialRecordLength buffer) { + return buffer.build(); + } Review comment: This method is going to be @override by PipelinedApproximateSubPartition later. But I think it might be confused if changing it here. I will inline the change for now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org