fsk119 commented on a change in pull request #13631:
URL: https://github.com/apache/flink/pull/13631#discussion_r506036775



##########
File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala
##########
@@ -268,7 +268,8 @@ class RefFieldAccessorVisitor(usedFields: Array[Int]) 
extends RexVisitorImpl[Uni
             // access is top-level access => return top-level access
             case _ :: _ if nestedAccess.equals("*") => List("*")
             // previous access is not prefix of this access => add access
-            case head :: _ if !nestedAccess.startsWith(head) =>
+            // it may cause bug without "." as tail if we have references a.b 
and a.bb
+            case head :: _ if !nestedAccess.startsWith(head + ".") =>

Review comment:
       I have use qualified name list to determine whether the element has been 
added into new schema.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to