godfreyhe commented on a change in pull request #13625:
URL: https://github.com/apache/flink/pull/13625#discussion_r506906883
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/reuse/DeadlockBreakupProcessor.scala
##########
@@ -146,22 +146,33 @@ class DeadlockBreakupProcessor extends DAGProcessor {
class DeadlockBreakupVisitor(finder: ReuseNodeFinder) extends
ExecNodeVisitorImpl {
- private def rewriteJoin(
- join: BatchExecJoinBase,
- leftIsBuild: Boolean,
- distribution: FlinkRelDistribution): Unit = {
- val (buildSideIndex, probeSideIndex) = if (leftIsBuild) (0, 1) else (1,
0)
- val buildNode = join.getInputNodes.get(buildSideIndex)
- val probeNode = join.getInputNodes.get(probeSideIndex)
+ private def rewriteTwoInputNode(
+ node: ExecNode[_, _],
+ leftPriority: Int,
+ requiredShuffle: ExecEdge.RequiredShuffle): Unit = {
+ val (buildSideIndex, probeSideIndex) = if (leftPriority == 0) (0, 1)
else (1, 0)
Review comment:
the highest priority is always 0? do we have this guarantee?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
