kottmann commented on pull request #13457: URL: https://github.com/apache/flink/pull/13457#issuecomment-713200967
I changed it as suggested in the log4j.properties and the log4j-console.properties. The MAX_LOG_FILE_NUMBER environment variable is not set for the started Java process, therefore I added an export to expose it, otherwise the default (10 as specified in the log4j properties) is always used. The two defaults could be confusing, what do you think about not specifying it in the log4j properties? If there are no bugs in the shell scripts MAX_LOG_FILE_NUMBER should be used anyway (defaults to 5) or to the user configured value. If the variable fails to be set for some reason log4j defaults to 7. I would still propose these changes before merge: - Remove the default form the log4j properties files - Increase the default from 5 to 10 - Add the on startup triggering policy for the log4j-console.properties file ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
