Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-188301093
Thanks @tillrohrmann, I'll fix the errors in the comments and add the
missing methods and extensions.
Regarding the import mode, I agree with you. I started off with just one
`DataSet` but then had to support many, I'll try to go back to the original
design while retaining multiple ´DataSet´ subtype extensions.
The only thing I'm not very convinced of from your snippet is about
returning the extended `DataStreamWithPartialFunctionSupport` class. Implicit
conversions have no runtime cost, so maybe it would be better to just return
the `DataSet` to make the code more compact and readable. What do you think?
Regarding the tests: I actually have some tests in place locally but
basically they're just copies of the original tests on the operators. Should I
commit them as well?
Regarding the docs: absolutely, I wasn't sure about this. Where do you
think it would be better to put them? Should I add a new chapter under the
programming guides?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
