rmetzger commented on a change in pull request #13690:
URL: https://github.com/apache/flink/pull/13690#discussion_r510669615



##########
File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -294,6 +294,13 @@
                                "they doesn't need to be downloaded every time 
for each application. An example could be " +
                                "hdfs://$namenode_address/path/of/flink/lib");
 
+       public static final ConfigOption<List<String>> YARN_ACCESS =
+               key("yarn.access.hadoopFileSystems")

Review comment:
       I believe it would be better to use 
`yarn.security.kerberos.additionalFileSystems`, because we have already a 
config key prefixed with `yarn.security.kerberos.` in the `yarn.` keys.

##########
File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -294,6 +294,13 @@
                                "they doesn't need to be downloaded every time 
for each application. An example could be " +
                                "hdfs://$namenode_address/path/of/flink/lib");
 
+       public static final ConfigOption<List<String>> YARN_ACCESS =
+               key("yarn.access.hadoopFileSystems")
+                       .stringType()
+                       .asList()
+                       .noDefaultValue()
+                       .withDescription("If you have extra Hadoop filesystems 
and enabled security, list all of those URLs.");

Review comment:
       ```suggestion
                        .withDescription("A comma-separated list of additional 
Kerberos-secured Hadoop filesystems Flink is going to access. For example, 
yarn.security.kerberos.additionalFileSystems=hdfs://namenode2:9002,hdfs://namenode3:9003.
 The client submitting to YARN needs to have access to these file systems to 
retrieve the security tokens.");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to