vthinkxie commented on a change in pull request #13458:
URL: https://github.com/apache/flink/pull/13458#discussion_r510680612



##########
File path: 
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.ts
##########
@@ -80,5 +83,25 @@ export class JobCheckpointsDetailComponent implements OnInit 
{
       this.cdr.markForCheck();
       this.refresh();
     });
+    this.jobService.loadCheckpointConfig(this.jobDetail.jid).subscribe(config 
=> {
+      this.checkPointConfig = config;
+      this.cdr.markForCheck();
+    });
+  }
+
+  checkPointType(){

Review comment:
       it would be better to checkPointType as a value other than a function 
here
   then move the calculation to line 65




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to