leonardBang commented on a change in pull request #13300:
URL: https://github.com/apache/flink/pull/13300#discussion_r512078756
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/TemporalJoinUtil.scala
##########
@@ -198,7 +198,7 @@ object TemporalJoinUtil {
}
def isRowTimeTemporalJoinConditionCall(rexCall: RexCall): Boolean = {
- rexCall.getOperator == TEMPORAL_JOIN_CONDITION && rexCall.operands.length
> 3
+ rexCall.getOperator == TEMPORAL_JOIN_CONDITION && rexCall.operands.length
== 5
Review comment:
the PRIMARY_KEY is necessary for row time temporal join.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
