rmetzger commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-718145230


   > There is no benefit in having the generated files in git, it could just be 
step of the release process
   
   One benefit would be, that our release process is less complicated
   Second benefit is that it is easier to check that the generated NOTICE files 
are valid when you have to regenerate and commit them. With your approach, we 
would wait with that until the release, and it would only be done by a few 
"experts".
   
   I'm undecided here, just discussing to understand our options.
   I'll soon push an update that resolves all errors we have so far in our 
notice files.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to