AHeise commented on a change in pull request #13822:
URL: https://github.com/apache/flink/pull/13822#discussion_r514073629
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
##########
@@ -270,7 +271,13 @@
* ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER indicates that this
buffer represents a
* serialized checkpoint barrier of aligned exactly-once
checkpoint mode.
*/
- ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER(false, true, true,
false);
+ ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER(false, true, true,
false),
+
+ /**
+ * Indicates that this subpartition state is fully recovered
(emitted).
+ * Further data can be consumed after unblocking.
+ */
+ RECOVERY_COMPLETION(false, true, true, false);
Review comment:
We should probably generalize ALIGNED_EXACTLY_ONCE_CHECKPOINT_BARRIER +
RECOVERY_COMPLETION to some BLOCKING_EVENT type.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/UpstreamRecoveryTracker.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.io;
+
+import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import org.apache.flink.runtime.io.network.partition.consumer.InputGate;
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+import java.util.HashSet;
+
+final class UpstreamRecoveryTracker {
Review comment:
We should generalize it for all epochs. Not sure if we already do it in
this PR or then later.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -263,7 +269,8 @@ BufferAndBacklog pollBuffer() {
buffer = bufferConsumer.build();
- checkState(bufferConsumer.isFinished() ||
buffers.size() == 1,
+ checkState(bufferConsumer.isFinished() ||
buffers.size() == 1 ||
Review comment:
Why do we need that change here and not for aligned barriers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
