[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169637#comment-15169637
]
ASF GitHub Bot commented on FLINK-3521:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1723#discussion_r54291015
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/function/AllWindowFunction.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.streaming.api.scala.function
+
+import java.io.Serializable
+
+import org.apache.flink.annotation.Public
+import org.apache.flink.api.common.functions.Function
+import org.apache.flink.streaming.api.windowing.windows.Window
+import org.apache.flink.util.Collector
+
+/**
+ * Base interface for functions that are evaluated over keyed (grouped)
windows.
--- End diff --
JavaDoc is wrong here
> Make Iterable part of method signature for WindowFunction
> ---------------------------------------------------------
>
> Key: FLINK-3521
> URL: https://issues.apache.org/jira/browse/FLINK-3521
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
>
> After discussion with [~StephanEwen],[~rmetzger], [~fhueske] it was decided
> that the signature of WindowFunction should be changed.
> Right now, the signature is {{WindowFunction<IN, OUT, KEY, WINDOW>}}. With
> the decision of whether the input is an {{Iterable}} nor not residing in the
> signature of the method on {{WindowedStream}}, for example:
> - {{WindowedStream.apply(WindowFunction<Iterable<IN>>, OUT, KEY, WINDOW>}}
> - {{WindowedStream.apply(ReduceFunction, WindowFunction<IN, OUT, KEY,
> WINDOW>}}
> The {{Iterable<>}} should be moved into the signature of the {{apply}}
> method, so that it is:
> {{void apply(KEY key, W window, Iterable<IN> input, Collector<OUT> out)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
